Subaru ej18

On the older model subarus, if the idle speed couldn't be kept under control by the idle speed controller, the ecu killed the spark to number one cylinder, and if that wasn't enough, to anothe cylinder which I don't recall.

Perhaps there is an air leak making it idle high, and, perhaps related, I see it's pinking too. Are you sure the diaphrams on the dissy are working and connected to the right places. Sometimes, on the two diaphram advancers, one diaphram is an "un-advancer". One diaphram might have a hole in it.

Have you checked the compressions ?
Are you certain the cam timing marks are as they are meant to be? Are you sure you are using the right marks ?
On the ej20 there is an arrow on the crank belt sprocket, which is meant to aim off to the right as you are looking at it, to the three oclock position, and then on one of the timing pulse bumps there is a small indent/line that lines up with another small indent in the aluminuun cover behind it. The indents are not vertical and on the case join, they are off to the right by about two mills or so.
If that is out two cylinders could have retarded exhaust closing and make it not run till the revs get up. just like a burnt valve will. And it could cause the ignition timing to be out if it's using a cam sensor to set the firing. And that could cause the pinking. if it's like the ej15 and doesn't have a knock detector.

ok worked it out The 1994 motor that i put in Has an extra node on the crank cutter gear which made the timing run to far advenced Took it off
and put the 1990 one on then retimed the cams and of she went. Thanks guys for your input. I will know next time.

thank you for telling the fix to your problem

Well done that man. And yeah, thanks for the feedback. We all learnt something.